26653b196b
Refactor the webhook logic, to have the type-dependent processing happen only in one place. --- ## Current webhook flow 1. An event happens 2. It is pre-processed (depending on the webhook type) and its body is added to a task queue 3. When the task is processed, some more logic (depending on the webhook type as well) is applied to make an HTTP request This means that webhook-type dependant logic is needed in step 2 and 3. This is cumbersome and brittle to maintain. Updated webhook flow with this PR: 1. An event happens 2. It is stored as-is and added to a task queue 3. When the task is processed, the event is processed (depending on the webhook type) to make an HTTP request So the only webhook-type dependent logic happens in one place (step 3) which should be much more robust. ## Consequences of the refactor - the raw event must be stored in the hooktask (until now, the pre-processed body was stored) - to ensure that previous hooktasks are correctly sent, a `payload_version` is added (version 1: the body has already been pre-process / version 2: the body is the raw event) So future webhook additions will only have to deal with creating an http.Request based on the raw event (no need to adjust the code in multiple places, like currently). Moreover since this processing happens when fetching from the task queue, it ensures that the queuing of new events (upon a `git push` for instance) does not get slowed down by a slow webhook. As a concrete example, the PR #19307 for custom webhooks, should be substantially smaller: - no need to change `services/webhook/deliver.go` - minimal change in `services/webhook/webhook.go` (add the new webhook to the map) - no need to change all the individual webhook files (since with this refactor the `*webhook_model.Webhook` is provided as argument)
108 lines
4.3 KiB
Go
108 lines
4.3 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package webhook
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
webhook_model "code.gitea.io/gitea/models/webhook"
|
|
"code.gitea.io/gitea/modules/json"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
webhook_module "code.gitea.io/gitea/modules/webhook"
|
|
)
|
|
|
|
// payloadConvertor defines the interface to convert system payload to webhook payload
|
|
type payloadConvertor[T any] interface {
|
|
Create(*api.CreatePayload) (T, error)
|
|
Delete(*api.DeletePayload) (T, error)
|
|
Fork(*api.ForkPayload) (T, error)
|
|
Issue(*api.IssuePayload) (T, error)
|
|
IssueComment(*api.IssueCommentPayload) (T, error)
|
|
Push(*api.PushPayload) (T, error)
|
|
PullRequest(*api.PullRequestPayload) (T, error)
|
|
Review(*api.PullRequestPayload, webhook_module.HookEventType) (T, error)
|
|
Repository(*api.RepositoryPayload) (T, error)
|
|
Release(*api.ReleasePayload) (T, error)
|
|
Wiki(*api.WikiPayload) (T, error)
|
|
Package(*api.PackagePayload) (T, error)
|
|
}
|
|
|
|
func convertUnmarshalledJSON[T, P any](convert func(P) (T, error), data []byte) (T, error) {
|
|
var p P
|
|
if err := json.Unmarshal(data, &p); err != nil {
|
|
var t T
|
|
return t, fmt.Errorf("could not unmarshal payload: %w", err)
|
|
}
|
|
return convert(p)
|
|
}
|
|
|
|
func newPayload[T any](rc payloadConvertor[T], data []byte, event webhook_module.HookEventType) (T, error) {
|
|
switch event {
|
|
case webhook_module.HookEventCreate:
|
|
return convertUnmarshalledJSON(rc.Create, data)
|
|
case webhook_module.HookEventDelete:
|
|
return convertUnmarshalledJSON(rc.Delete, data)
|
|
case webhook_module.HookEventFork:
|
|
return convertUnmarshalledJSON(rc.Fork, data)
|
|
case webhook_module.HookEventIssues, webhook_module.HookEventIssueAssign, webhook_module.HookEventIssueLabel, webhook_module.HookEventIssueMilestone:
|
|
return convertUnmarshalledJSON(rc.Issue, data)
|
|
case webhook_module.HookEventIssueComment, webhook_module.HookEventPullRequestComment:
|
|
// previous code sometimes sent s.PullRequest(p.(*api.PullRequestPayload))
|
|
// however I couldn't find in notifier.go such a payload with an HookEvent***Comment event
|
|
|
|
// History (most recent first):
|
|
// - refactored in https://github.com/go-gitea/gitea/pull/12310
|
|
// - assertion added in https://github.com/go-gitea/gitea/pull/12046
|
|
// - issue raised in https://github.com/go-gitea/gitea/issues/11940#issuecomment-645713996
|
|
// > That's because for HookEventPullRequestComment event, some places use IssueCommentPayload and others use PullRequestPayload
|
|
|
|
// In modules/actions/workflows.go:183 the type assertion is always payload.(*api.IssueCommentPayload)
|
|
return convertUnmarshalledJSON(rc.IssueComment, data)
|
|
case webhook_module.HookEventPush:
|
|
return convertUnmarshalledJSON(rc.Push, data)
|
|
case webhook_module.HookEventPullRequest, webhook_module.HookEventPullRequestAssign, webhook_module.HookEventPullRequestLabel,
|
|
webhook_module.HookEventPullRequestMilestone, webhook_module.HookEventPullRequestSync, webhook_module.HookEventPullRequestReviewRequest:
|
|
return convertUnmarshalledJSON(rc.PullRequest, data)
|
|
case webhook_module.HookEventPullRequestReviewApproved, webhook_module.HookEventPullRequestReviewRejected, webhook_module.HookEventPullRequestReviewComment:
|
|
return convertUnmarshalledJSON(func(p *api.PullRequestPayload) (T, error) {
|
|
return rc.Review(p, event)
|
|
}, data)
|
|
case webhook_module.HookEventRepository:
|
|
return convertUnmarshalledJSON(rc.Repository, data)
|
|
case webhook_module.HookEventRelease:
|
|
return convertUnmarshalledJSON(rc.Release, data)
|
|
case webhook_module.HookEventWiki:
|
|
return convertUnmarshalledJSON(rc.Wiki, data)
|
|
case webhook_module.HookEventPackage:
|
|
return convertUnmarshalledJSON(rc.Package, data)
|
|
}
|
|
var t T
|
|
return t, fmt.Errorf("newPayload unsupported event: %s", event)
|
|
}
|
|
|
|
func newJSONRequest[T any](pc payloadConvertor[T], w *webhook_model.Webhook, t *webhook_model.HookTask, withDefaultHeaders bool) (*http.Request, []byte, error) {
|
|
payload, err := newPayload(pc, []byte(t.PayloadContent), t.EventType)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
body, err := json.MarshalIndent(payload, "", " ")
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
req, err := http.NewRequest(w.HTTPMethod, w.URL, bytes.NewReader(body))
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
req.Header.Set("Content-Type", "application/json")
|
|
|
|
if withDefaultHeaders {
|
|
return req, body, addDefaultHeaders(req, []byte(w.Secret), t, body)
|
|
}
|
|
return req, body, nil
|
|
}
|