From d2693f18de2bd85f9e2e700bef5f38270a9e5591 Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Mon, 20 Apr 2020 15:10:45 +0200 Subject: [PATCH] Support organization labels for PRs in API (#11135) Fix `/repos/{owner}/{repo}/pulls` and `/repos/{owner}/{repo}/pulls/{index}` to accept organization labels during PR creation and edition. --- routers/api/v1/repo/pull.go | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go index b23d502c6..db0b14bd7 100644 --- a/routers/api/v1/repo/pull.go +++ b/routers/api/v1/repo/pull.go @@ -241,10 +241,26 @@ func CreatePullRequest(ctx *context.APIContext, form api.CreatePullRequestOption return } - labelIDs = make([]int64, len(labels)) + labelIDs = make([]int64, len(form.Labels)) + orgLabelIDs := make([]int64, len(form.Labels)) + for i := range labels { labelIDs[i] = labels[i].ID } + + if ctx.Repo.Owner.IsOrganization() { + orgLabels, err := models.GetLabelsInOrgByIDs(ctx.Repo.Owner.ID, form.Labels) + if err != nil { + ctx.Error(http.StatusInternalServerError, "GetLabelsInOrgByIDs", err) + return + } + + for i := range orgLabels { + orgLabelIDs[i] = orgLabels[i].ID + } + } + + labelIDs = append(labelIDs, orgLabelIDs...) } if form.Milestone > 0 { @@ -452,6 +468,17 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) { ctx.Error(http.StatusInternalServerError, "GetLabelsInRepoByIDsError", err) return } + + if ctx.Repo.Owner.IsOrganization() { + orgLabels, err := models.GetLabelsInOrgByIDs(ctx.Repo.Owner.ID, form.Labels) + if err != nil { + ctx.Error(http.StatusInternalServerError, "GetLabelsInOrgByIDs", err) + return + } + + labels = append(labels, orgLabels...) + } + if err = issue.ReplaceLabels(labels, ctx.User); err != nil { ctx.Error(http.StatusInternalServerError, "ReplaceLabelsError", err) return